pricelees/roomescape-refactored
1
0
Fork 0
generated from pricelees/issue-pr-template
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

test: 기존의 view 로직 마이그레이션 및 클래스 통합

Browse Source
This commit is contained in:
이상진 2025-07-12 17:59:49 +09:00
parent db5d4f7c4d
commit 1c57f06630
4 changed files with 161 additions and 346 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

219
src/test/java/roomescape/view/controller/AdminPageControllerTest.java
View File

@ -1,219 +0,0 @@
package roomescape.view.controller;
import java.util.Map;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.web.server.LocalServerPort;
import org.springframework.test.context.jdbc.Sql;
import io.restassured.RestAssured;
import io.restassured.http.ContentType;
import io.restassured.http.Header;
import roomescape.member.domain.Member;
import roomescape.member.domain.Role;
import roomescape.member.domain.repository.MemberRepository;
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@Sql(scripts = "/truncate.sql", executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD)
class AdminPageControllerTest {
@Autowired
private MemberRepository memberRepository;
@LocalServerPort
private int port;
@Test
@DisplayName("관리자 권한이 있는 유저가 /admin 으로 GET 요청을 보내면 어드민 페이지와 200 OK 를 받는다.")
void getAdminPageHasRole() {
// given
String adminAccessTokenCookie = getAdminAccessTokenCookieByLogin("admin@admin.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", adminAccessTokenCookie))
.when().get("/admin")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("관리자 권한이 없는 유저가 /admin 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getAdminPageHasNotRole() {
// given
String accessTokenCookie = getAccessTokenCookieByLogin("member@member.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", accessTokenCookie))
.when().get("/admin")
.then().log().all()
.statusCode(200)
.body(Matchers.containsString("<title>Login</title>"));
}
@Test
@DisplayName("/admin/reservation 으로 GET 요청을 보내면 어드민 예약 관리 페이지와 200 OK 를 받는다.")
void getAdminReservationPageHasRole() {
// given
String adminAccessTokenCookie = getAdminAccessTokenCookieByLogin("admin@admin.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", adminAccessTokenCookie))
.when().get("/admin/reservation")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("관리자 권한이 없는 유저가 /admin/reservation 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getAdminReservationPageHasNotRole() {
// given
String accessTokenCookie = getAccessTokenCookieByLogin("member@member.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", accessTokenCookie))
.when().get("/admin/reservation")
.then().log().all()
.statusCode(200)
.body(Matchers.containsString("<title>Login</title>"));
}
@Test
@DisplayName("/admin/time 으로 GET 요청을 보내면 어드민 예약 시간 관리 페이지와 200 OK 를 받는다.")
void getAdminTimePageHasRole() {
// given
String adminAccessTokenCookie = getAdminAccessTokenCookieByLogin("admin@admin.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", adminAccessTokenCookie))
.when().get("/admin/time")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("관리자 권한이 없는 유저가 /admin/time 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getAdminTimePageHasNotRole() {
// given
String accessTokenCookie = getAccessTokenCookieByLogin("member@member.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", accessTokenCookie))
.when().get("/admin/time")
.then().log().all()
.statusCode(200)
.body(Matchers.containsString("<title>Login</title>"));
}
@Test
@DisplayName("관리자 권한이 있는 유저가 /admin/theme 으로 GET 요청을 보내면 어드민 테마 관리 페이지와 200 OK 를 받는다.")
void getAdminThemePageHasRole() {
// given
String adminAccessTokenCookie = getAdminAccessTokenCookieByLogin("admin@admin.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", adminAccessTokenCookie))
.when().get("/admin/theme")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("관리자 권한이 없는 유저가 /admin/theme 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getAdminThemePageHasNotRole() {
// given
String accessTokenCookie = getAccessTokenCookieByLogin("member@member.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", accessTokenCookie))
.when().get("/admin/theme")
.then().log().all()
.statusCode(200)
.body(Matchers.containsString("<title>Login</title>"));
}
@Test
@DisplayName("관리자 권한이 있는 유저가 /admin/waiting 으로 GET 요청을 보내면 어드민 대기 관리 페이지와 200 OK 를 받는다.")
void getAdminWatingPage() {
// given
String adminAccessTokenCookie = getAdminAccessTokenCookieByLogin("admin@email.com", "12341234");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", adminAccessTokenCookie))
.when().get("/admin/waiting")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("관리자 권한이 없는 유저가 /admin/waiting 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getAdminWaitingPageHasNotRole() {
// given
String accessTokenCookie = getAccessTokenCookieByLogin("member@email.com", "member");
// when & then
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", accessTokenCookie))
.when().get("/admin/waiting")
.then().log().all()
.statusCode(200)
.body(Matchers.containsString("<title>Login</title>"));
}
private String getAdminAccessTokenCookieByLogin(String email, String password) {
memberRepository.save(new Member("이름", email, password, Role.ADMIN));
Map<String, String> loginParams = Map.of(
"email", email,
"password", password
);
String accessToken = RestAssured.given().log().all()
.contentType(ContentType.JSON)
.port(port)
.body(loginParams)
.when().post("/login")
.then().log().all().extract().cookie("accessToken");
return "accessToken=" + accessToken;
}
private String getAccessTokenCookieByLogin(String email, String password) {
memberRepository.save(new Member("name", email, password, Role.MEMBER));
Map<String, String> loginParams = Map.of(
"email", email,
"password", password
);
String accessToken = RestAssured.given().log().all()
.contentType(ContentType.JSON)
.port(port)
.body(loginParams)
.when().post("/login")
.then().log().all().extract().cookie("accessToken");
return "accessToken=" + accessToken;
}
}

25
src/test/java/roomescape/view/controller/AuthPageControllerTest.java
View File

@ -1,25 +0,0 @@
package roomescape.view.controller;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.web.server.LocalServerPort;
import io.restassured.RestAssured;
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
class AuthPageControllerTest {
@LocalServerPort
private int port;
@Test
@DisplayName("/login 으로 GET 요청을 보내면 login 페이지와 200 OK 를 받는다.")
void getMainPage() {
RestAssured.given().log().all()
.port(port)
.when().get("/login")
.then().log().all()
.statusCode(200);
}
}

102
src/test/java/roomescape/view/controller/ClientPageControllerTest.java
View File

@ -1,102 +0,0 @@
package roomescape.view.controller;
import static org.hamcrest.Matchers.*;
import java.util.Map;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.web.server.LocalServerPort;
import org.springframework.test.context.jdbc.Sql;
import io.restassured.RestAssured;
import io.restassured.http.ContentType;
import io.restassured.http.Header;
import roomescape.member.domain.Member;
import roomescape.member.domain.Role;
import roomescape.member.domain.repository.MemberRepository;
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@Sql(scripts = "/truncate.sql", executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD)
class ClientPageControllerTest {
@Autowired
private MemberRepository memberRepository;
@LocalServerPort
private int port;
@Test
@DisplayName("/ 으로 GET 요청을 보내면 index 페이지와 200 OK 를 받는다.")
void getMainPage() {
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", getAccessTokenCookieByLogin("email@email.com", "password")))
.when().get("/")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("/reservation 으로 GET 요청을 보내면 방탈출 예약 페이지와 200 OK 를 받는다.")
void getReservationPage() {
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", getAccessTokenCookieByLogin("email@email.com", "password")))
.when().get("/reservation")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("로그인 없이 /reservation 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getReservationPageWithoutLogin() {
RestAssured.given().log().all()
.port(port)
.when().get("/reservation")
.then().log().all()
.statusCode(200)
.body(containsString("<title>Login</title>"));
}
@Test
@DisplayName("/reservation-mine 으로 GET 요청을 보내면 방탈출 예약 페이지와 200 OK 를 받는다.")
void getMyReservationPage() {
RestAssured.given().log().all()
.port(port)
.header(new Header("Cookie", getAccessTokenCookieByLogin("email@email.com", "password")))
.when().get("/reservation-mine")
.then().log().all()
.statusCode(200);
}
@Test
@DisplayName("로그인 없이 /reservation-mine 으로 GET 요청을 보내면 로그인 페이지로 리다이렉트 된다.")
void getMyReservationPageWithoutLogin() {
RestAssured.given().log().all()
.port(port)
.when().get("/reservation-mine")
.then().log().all()
.statusCode(200)
.body(containsString("<title>Login</title>"));
}
private String getAccessTokenCookieByLogin(String email, String password) {
memberRepository.save(new Member("name", email, password, Role.MEMBER));
Map<String, String> loginParams = Map.of(
"email", email,
"password", password
);
String accessToken = RestAssured.given().log().all()
.contentType(ContentType.JSON)
.port(port)
.body(loginParams)
.when().post("/login")
.then().log().all().extract().cookie("accessToken");
return "accessToken=" + accessToken;
}
}

161
src/test/java/roomescape/view/controller/PageControllerTest.kt Normal file
View File

@ -0,0 +1,161 @@
package roomescape.view.controller
import com.ninjasquad.springmockk.MockkBean
import io.kotest.core.spec.style.BehaviorSpec
import io.mockk.every
import io.restassured.module.kotlin.extensions.Given
import io.restassured.module.kotlin.extensions.Then
import io.restassured.module.kotlin.extensions.When
import io.restassured.response.ValidatableResponse
import org.hamcrest.Matchers.containsString
import org.springframework.boot.test.context.SpringBootTest
import org.springframework.boot.test.web.server.LocalServerPort
import org.springframework.http.HttpStatus
import roomescape.common.MemberFixture
import roomescape.common.NoSqlInitialize
import roomescape.member.domain.Member
import roomescape.member.service.MemberService
import roomescape.system.auth.jwt.JwtHandler
import roomescape.system.exception.ErrorType
import roomescape.system.exception.RoomEscapeException
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@NoSqlInitialize
class PageControllerTest(
@LocalServerPort val port: Int,
) : BehaviorSpec() {
@MockkBean
private lateinit var jwtHandler: JwtHandler
@MockkBean
private lateinit var memberService: MemberService
private val admin: Member = MemberFixture.admin()
private val user: Member = MemberFixture.user()
init {
listOf("/", "/login").forEach {
given("GET $it 요청은") {
`when`("로그인 및 권한 여부와 관계없이 성공한다.") {
then("비회원") {
runTest(it) {
statusCode(200)
}
}
then("회원") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns user.id
runTest(it) {
statusCode(200)
}
}
then("관리자") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns admin.id
runTest(it) {
statusCode(200)
}
}
}
}
}
listOf("/admin", "/admin/reservation", "/admin/time", "/admin/theme", "/admin/waiting").forEach {
given("GET $it 요청을") {
`when`("관리자가 보내면") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns admin.id
then("성공한다.") {
runTest(it) {
statusCode(200)
}
}
}
`when`("회원이 보내면") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns user.id
then("로그인 페이지로 이동한다.") {
runTest(it) {
statusCode(200)
body(containsString("<title>Login</title>"))
}
}
}
}
}
listOf("/reservation", "/reservation-mine").forEach {
given("GET $it 요청을") {
`when`("로그인 된 회원이 보내면 성공한다.") {
then("회원") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns user.id
runTest(it) {
statusCode(200)
}
}
then("관리자") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns admin.id
runTest(it) {
statusCode(200)
}
}
}
`when`("로그인 없이 보내면") {
then("로그인 페이지로 이동한다.") {
every {
jwtHandler.getMemberIdFromToken(any())
} returns null
runTest(it) {
statusCode(200)
body(containsString("<title>Login</title>"))
}
}
}
}
}
}
fun runTest(endpoint: String, assert: ValidatableResponse.() -> Unit) {
setUpMocks()
Given {
port(port)
header("Cookie", "accessToken=token")
} When {
get(endpoint)
} Then assert
}
private fun setUpMocks() {
every { memberService.findMemberById(admin.id) } returns admin
every { memberService.findMemberById(user.id) } returns user
every { memberService.findMemberById(null) } throws RoomEscapeException(
ErrorType.MEMBER_NOT_FOUND,
String.format("[memberId: %d]", null),
HttpStatus.BAD_REQUEST
)
}
}