refactor: member 도매인 내 findById가 Entity가 아닌 DTO를 반혼하도록 수정

This commit is contained in:
이상진 2025-09-07 21:20:30 +09:00
parent 0ac0277714
commit c43836c2dc
2 changed files with 22 additions and 5 deletions

View File

@ -5,7 +5,6 @@ import org.springframework.stereotype.Service
import org.springframework.transaction.annotation.Transactional import org.springframework.transaction.annotation.Transactional
import roomescape.member.implement.MemberFinder import roomescape.member.implement.MemberFinder
import roomescape.member.implement.MemberWriter import roomescape.member.implement.MemberWriter
import roomescape.member.infrastructure.persistence.MemberEntity
import roomescape.member.infrastructure.persistence.Role import roomescape.member.infrastructure.persistence.Role
import roomescape.member.web.* import roomescape.member.web.*
@ -26,11 +25,14 @@ class MemberService(
} }
@Transactional(readOnly = true) @Transactional(readOnly = true)
fun findById(memberId: Long): MemberEntity { fun findSummaryById(id: Long): MemberSummaryRetrieveResponse {
log.debug { "[MemberService.findById] 시작" } log.debug { "[MemberService.findSummaryById] 시작" }
return memberFinder.findById(memberId) return memberFinder.findById(id)
.also { log.info { "[MemberService.findById] 완료. memberId=${memberId}, email=${it.email}" } } .toSummaryRetrieveResponse()
.also {
log.info { "[MemberService.findSummaryById] 완료. memberId=${id}, email=${it.email}" }
}
} }
@Transactional @Transactional

View File

@ -2,6 +2,7 @@ package roomescape.member.web
import io.swagger.v3.oas.annotations.media.Schema import io.swagger.v3.oas.annotations.media.Schema
import roomescape.member.infrastructure.persistence.MemberEntity import roomescape.member.infrastructure.persistence.MemberEntity
import roomescape.member.infrastructure.persistence.Role
fun MemberEntity.toRetrieveResponse(): MemberRetrieveResponse = MemberRetrieveResponse( fun MemberEntity.toRetrieveResponse(): MemberRetrieveResponse = MemberRetrieveResponse(
id = id!!, id = id!!,
@ -39,3 +40,17 @@ fun MemberEntity.toSignupResponse(): SignupResponse = SignupResponse(
id = this.id!!, id = this.id!!,
name = this.name name = this.name
) )
data class MemberSummaryRetrieveResponse(
val id: Long,
val name: String,
val email: String,
val role: Role
)
fun MemberEntity.toSummaryRetrieveResponse() = MemberSummaryRetrieveResponse(
id = this.id!!,
name = this.name,
email = this.email,
role = this.role
)