From f4d7b304527f380580566e2cef5396cc209201f2 Mon Sep 17 00:00:00 2001
From: pricelees <priceelees@gmail.com>
Date: Sun, 14 Sep 2025 16:21:04 +0900
Subject: [PATCH] =?UTF-8?q?refactor:=20DataParser=20=EB=82=B4=20=EC=83=81?=
 =?UTF-8?q?=EC=88=98=ED=99=94=20=EB=B0=8F=20=ED=95=84=ED=84=B0=EB=A7=81=20?=
 =?UTF-8?q?=EC=B2=98=EB=A6=AC=20=EC=88=98=EC=A0=95?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/test/kotlin/roomescape/data/DataParser.kt | 34 +++++++++++--------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/src/test/kotlin/roomescape/data/DataParser.kt b/src/test/kotlin/roomescape/data/DataParser.kt
index 1b7ed25f..86acb0d9 100644
--- a/src/test/kotlin/roomescape/data/DataParser.kt
+++ b/src/test/kotlin/roomescape/data/DataParser.kt
@@ -4,12 +4,19 @@ import io.kotest.core.spec.style.StringSpec
 import org.apache.poi.xssf.usermodel.XSSFWorkbook
 import java.io.File
 
+const val BASE_DIR = "data"
+const val PARSED_REGION_POPULATION_FILE = "$BASE_DIR/region_population.txt"
+const val REGION_SQL_FILE = "data/region.sql"
+const val MIN_POPULATION_FOR_PER_STORE = 200_000
+
+/**
+ * 행안부 202508 인구 동향 데이터 사용( /data/population.xlsx )
+ */
 class PopulationDataSqlParser() : StringSpec({
 
     val regionCodePattern = Regex("^[0-9]{10}$")
-    val minPopulation = 250_000
 
-    "인구 데이터를 이용하여 지역 정보 SQL 파일로 변환하고, 추가로 $minPopulation 이상의 시/군/구는 매장 데이터 생성을 위해 따로 분류한다." {
+    "인구 데이터를 이용하여 지역 정보 SQL 파일로 변환하고, 추가로 $MIN_POPULATION_FOR_PER_STORE 이상의 시/군/구는 매장 데이터 생성을 위해 따로 분류한다." {
         val populationXlsx = XSSFWorkbook(File("data/population.xlsx"))
         val sheet = populationXlsx.getSheetAt(0)
         val allRegion = mutableListOf<List<String>>()
@@ -30,47 +37,46 @@ class PopulationDataSqlParser() : StringSpec({
             }
 
             val regionName = row.getCell(1).stringCellValue
-
             if (!regionName.trim().contains(" ")) {
                 return@forEach
             }
+
             val parts = regionName.split(" ")
+            if (parts.size < 2) {
+                return@forEach
+            }
 
             val sidoName = parts[0].trim()
             val sigunguName = parts[1].trim()
-            val guName = if (parts.size > 2) parts[2].trim() else ""
-
             val populationInt = population.toInt()
 
             if (populationInt <= 0) {
                 return@forEach
             }
 
-            if (populationInt > minPopulation) {
+            if (populationInt >= MIN_POPULATION_FOR_PER_STORE) {
                 regionsMoreThanMinPopulation.add(listOf(
                         regionCode,
                         sidoCode,
                         sigunguCode,
                         sidoName,
                         sigunguName,
-                        guName,
                         population
                     )
                 )
-
             }
             allRegion.add(listOf(regionCode, sidoCode, sigunguCode, sidoName, sigunguName))
         }
 
         regionsMoreThanMinPopulation.filter {
+            val sidoName = it[3]
             val sigunguName = it[4]
-            val sameSigungu = regionsMoreThanMinPopulation.filter { r -> r[4] == sigunguName }
-            !((sameSigungu.size > 1) && (it[5].isNullOrBlank()))
+            val sameSigungu = allRegion.filter { r -> r[3] == sidoName && r[4] == sigunguName }
+            !((sameSigungu.size > 1) && sameSigungu.minByOrNull { r -> r[2].toInt() }!![2] != it[2])
         }.mapIndexed { idx, values ->
-            val guName = if (values[5].isNullOrBlank()) "NULL" else "'${values[5]}'"
-            "${values[0]}, ${values[1]}, ${values[2]}, ${values[3]}, ${values[4]}, $guName, ${values[6]}"
+            "${values[0]}, ${values[1]}, ${values[2]}, ${values[3]}, ${values[4]}, ${values[5]}"
         }.joinToString(separator = "\n").also {
-            File("data/region_population.txt").writeText(it)
+            File(PARSED_REGION_POPULATION_FILE).writeText(it)
         }
 
         allRegion.distinctBy { it[1] to it[2] }.filter {
@@ -84,7 +90,7 @@ class PopulationDataSqlParser() : StringSpec({
         ) { region ->
             "('${region[0]}', '${region[1]}', '${region[2]}', '${region[3]}', '${region[4]}')"
         }.also {
-            File("data/region.sql").writeText("${it};")
+            File(REGION_SQL_FILE).writeText("${it};")
         }
     }
 })