pricelees/roomescape-refactored
1
0
Fork 0
generated from pricelees/issue-pr-template
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

[#30] 코드 구조 개선 #31

Merged
pricelees merged 31 commits from refactor/#30 into main 2025-08-06 10:16:08 +00:00
Conversation 0 Commits 31 Files Changed 78 +1 -6
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4b568915ae - Show all commits

2
src/test/kotlin/roomescape/auth/infrastructure/jwt/JwtHandlerTest.kt
View File

@ -25,14 +25,12 @@ class JwtHandlerTest : FunSpec({
} }
test("만료된 토큰이면 예외를 던진다.") { test("만료된 토큰이면 예외를 던진다.") {
// given
val expirationTime = 0L val expirationTime = 0L
val shortExpirationTimeJwtHandler: JwtHandler = JwtFixture.create(expirationTime = expirationTime) val shortExpirationTimeJwtHandler: JwtHandler = JwtFixture.create(expirationTime = expirationTime)
val token = shortExpirationTimeJwtHandler.createToken(memberId) val token = shortExpirationTimeJwtHandler.createToken(memberId)
Thread.sleep(expirationTime) // 만료 시간 이후로 대기 Thread.sleep(expirationTime) // 만료 시간 이후로 대기
// when & then
shouldThrow<AuthException> { shouldThrow<AuthException> {
shortExpirationTimeJwtHandler.getMemberIdFromToken(token) shortExpirationTimeJwtHandler.getMemberIdFromToken(token)
}.errorCode shouldBe AuthErrorCode.EXPIRED_TOKEN }.errorCode shouldBe AuthErrorCode.EXPIRED_TOKEN

1
src/test/kotlin/roomescape/member/business/MemberServiceTest.kt
View File

@ -90,7 +90,6 @@ class MemberServiceTest : FunSpec({
memberWriter.create(request.name, request.email, request.password, Role.MEMBER) memberWriter.create(request.name, request.email, request.password, Role.MEMBER)
} throws MemberException(MemberErrorCode.DUPLICATE_EMAIL) } throws MemberException(MemberErrorCode.DUPLICATE_EMAIL)
// when & then
shouldThrow<MemberException> { shouldThrow<MemberException> {
memberService.createMember(request) memberService.createMember(request)
}.also { }.also {

4
src/test/kotlin/roomescape/payment/infrastructure/client/TossPaymentClientTest.kt
View File

@ -48,7 +48,6 @@ class TossPaymentClientTest(
.createResponse(it) .createResponse(it)
} }
// when
val paymentRequest = SampleTossPaymentConst.paymentRequest val paymentRequest = SampleTossPaymentConst.paymentRequest
val paymentResponse: PaymentApproveResponse = client.confirm(paymentRequest) val paymentResponse: PaymentApproveResponse = client.confirm(paymentRequest)
@ -68,7 +67,6 @@ class TossPaymentClientTest(
.createResponse(it) .createResponse(it)
} }
// when
val paymentRequest = SampleTossPaymentConst.paymentRequest val paymentRequest = SampleTossPaymentConst.paymentRequest
// then // then
@ -107,7 +105,7 @@ class TossPaymentClientTest(
.createResponse(it) .createResponse(it)
} }
// when
val cancelRequest: PaymentCancelRequest = SampleTossPaymentConst.cancelRequest val cancelRequest: PaymentCancelRequest = SampleTossPaymentConst.cancelRequest
val cancelResponse: PaymentCancelResponse = client.cancel(cancelRequest) val cancelResponse: PaymentCancelResponse = client.cancel(cancelRequest)