generated from pricelees/issue-pr-template
<!-- 제목 양식 --> <!-- [이슈번호] 작업 요약 (예시: [#10] Gitea 템플릿 생성) --> ## 📝 관련 이슈 및 PR **PR과 관련된 이슈 번호** - #13 ## ✨ 작업 내용 <!-- 어떤 작업을 했는지 알려주세요! --> theme 패키지 내 코드 및 테스트 코틀린 전환 ## 🧪 테스트 <!-- 어떤 테스트를 생각했고 진행했는지 알려주세요! --> 다른 테스트는 코틀린으로 전환 시 크게 문제가 없었으나, GET /themes/most-reserved-last-week API의 경우 쿼리에 크게 의존하여 mocking을 사용하는 기존 테스트로 처리하기 애매한 부분이 있었음. 따라서, API 테스트는 mocking이 아닌 RestAssured를 이용한 실제 테스트로 진행하였고 \@RequestParam, 날짜 등 실제 비즈니스와 관련된 부분을 위주로 처리하고 쿼리 자체는 Repository 테스트에서 상세하게 검증하였음. ## 📚 참고 자료 및 기타 <!-- 참고한 자료, 또는 논의할 사항이 있다면 알려주세요! --> 패키지를 reservation 안에 넣는 것은 고민이 조금 더 필요할 것 같음. 현재는 단일 매장에 대한 서비스지만 매장별로 분리하는 것을 고민중인 만큼 코틀린 마이그레이션이 끝난 이후 생각해볼 예정 Reviewed-on: #15 Co-authored-by: pricelees <priceelees@gmail.com> Co-committed-by: pricelees <priceelees@gmail.com>
132 lines
4.6 KiB
Kotlin
132 lines
4.6 KiB
Kotlin
package roomescape.util
|
|
|
|
import com.fasterxml.jackson.databind.ObjectMapper
|
|
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
|
|
import com.ninjasquad.springmockk.MockkBean
|
|
import com.ninjasquad.springmockk.SpykBean
|
|
import io.kotest.core.spec.style.BehaviorSpec
|
|
import io.mockk.every
|
|
import org.springframework.data.repository.findByIdOrNull
|
|
import org.springframework.http.HttpHeaders
|
|
import org.springframework.http.HttpStatus
|
|
import org.springframework.http.MediaType
|
|
import org.springframework.test.web.servlet.*
|
|
import roomescape.auth.infrastructure.jwt.JwtHandler
|
|
import roomescape.auth.web.support.AdminInterceptor
|
|
import roomescape.auth.web.support.LoginInterceptor
|
|
import roomescape.auth.web.support.MemberIdResolver
|
|
import roomescape.common.exception.ErrorType
|
|
import roomescape.common.exception.RoomescapeException
|
|
import roomescape.member.business.MemberService
|
|
import roomescape.member.infrastructure.persistence.Member
|
|
import roomescape.member.infrastructure.persistence.MemberRepository
|
|
import roomescape.util.MemberFixture.NOT_LOGGED_IN_USERID
|
|
|
|
abstract class RoomescapeApiTest : BehaviorSpec() {
|
|
|
|
@SpykBean
|
|
private lateinit var AdminInterceptor: AdminInterceptor
|
|
|
|
@SpykBean
|
|
private lateinit var loginInterceptor: LoginInterceptor
|
|
|
|
@SpykBean
|
|
private lateinit var memberIdResolver: MemberIdResolver
|
|
|
|
@SpykBean
|
|
lateinit var memberService: MemberService
|
|
|
|
@MockkBean
|
|
lateinit var memberRepository: MemberRepository
|
|
|
|
@MockkBean
|
|
lateinit var jwtHandler: JwtHandler
|
|
|
|
val objectMapper: ObjectMapper = jacksonObjectMapper()
|
|
val admin: Member = MemberFixture.admin()
|
|
val user: Member = MemberFixture.user()
|
|
|
|
fun runGetTest(
|
|
mockMvc: MockMvc,
|
|
endpoint: String,
|
|
log: Boolean = false,
|
|
assert: MockMvcResultMatchersDsl.() -> Unit
|
|
): ResultActionsDsl = mockMvc.get(endpoint) {
|
|
header(HttpHeaders.COOKIE, "accessToken=token")
|
|
}.apply {
|
|
log.takeIf { it }?.let { this.andDo { print() } }
|
|
}.andExpect(assert)
|
|
|
|
fun runPostTest(
|
|
mockMvc: MockMvc,
|
|
endpoint: String,
|
|
body: Any? = null,
|
|
log: Boolean = false,
|
|
assert: MockMvcResultMatchersDsl.() -> Unit
|
|
): ResultActionsDsl = mockMvc.post(endpoint) {
|
|
this.header(HttpHeaders.COOKIE, "accessToken=token")
|
|
body?.let {
|
|
this.contentType = MediaType.APPLICATION_JSON
|
|
this.content = objectMapper.writeValueAsString(it)
|
|
}
|
|
}.apply {
|
|
log.takeIf { it }?.let { this.andDo { print() } }
|
|
}.andExpect {
|
|
assert
|
|
}
|
|
|
|
fun runDeleteTest(
|
|
mockMvc: MockMvc,
|
|
endpoint: String,
|
|
log: Boolean = false,
|
|
assert: MockMvcResultMatchersDsl.() -> Unit
|
|
): ResultActionsDsl = mockMvc.delete(endpoint) {
|
|
header(HttpHeaders.COOKIE, "accessToken=token")
|
|
}.apply {
|
|
log.takeIf { it }?.let { this.andDo { print() } }
|
|
}.andExpect {
|
|
assert
|
|
}
|
|
|
|
fun loginAsAdmin() {
|
|
every {
|
|
jwtHandler.getMemberIdFromToken(any())
|
|
} returns admin.id!!
|
|
|
|
every { memberRepository.existsById(admin.id!!) } returns true
|
|
every { memberRepository.findByIdOrNull(admin.id!!) } returns admin
|
|
}
|
|
|
|
fun loginAsUser() {
|
|
every {
|
|
jwtHandler.getMemberIdFromToken(any())
|
|
} returns user.id!!
|
|
|
|
every { memberRepository.existsById(user.id!!) } returns true
|
|
every { memberRepository.findByIdOrNull(user.id!!) } returns user
|
|
}
|
|
|
|
fun doNotLogin() {
|
|
every {
|
|
jwtHandler.getMemberIdFromToken(any())
|
|
} throws RoomescapeException(ErrorType.INVALID_TOKEN, HttpStatus.UNAUTHORIZED)
|
|
|
|
every { memberRepository.existsById(NOT_LOGGED_IN_USERID) } returns false
|
|
every { memberRepository.findByIdOrNull(NOT_LOGGED_IN_USERID) } returns null
|
|
}
|
|
|
|
fun <T> MvcResult.readValue(valueType: Class<T>): T = this.response.contentAsString
|
|
.takeIf { it.isNotBlank() }
|
|
?.let { readValue(it, valueType) }
|
|
?: throw RuntimeException("""
|
|
[Test] Exception occurred while reading response json: ${this.response.contentAsString} with value type: $valueType
|
|
""".trimIndent())
|
|
|
|
fun <T> readValue(responseJson: String, valueType: Class<T>): T = objectMapper
|
|
.readTree(responseJson)["data"]
|
|
?.let { objectMapper.convertValue(it, valueType) }
|
|
?: throw RuntimeException("""
|
|
[Test] Exception occurred while reading response json: $responseJson with value type: $valueType
|
|
""".trimIndent())
|
|
}
|