pricelees/understanding-kafka-consumer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: ConsumerWorker에서의 메서드 및 변수 분리

Browse Source 
- finally 구문에서 실행되는 종료 로직을 closeAfterManualCommit() 으로 분리

- consumer.commitAsync에 들어가는 OffsetCommitCallback을 변수로 분리
This commit is contained in:
이상진 2025-06-27 15:07:15 +09:00
parent c348ae6dbd
commit 77ee1dff8c
1 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/main/java/com/sangdol/consumer/infrastructure/kafka/consumer/ConsumerWorker.java
View File

@ -10,6 +10,7 @@ import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.consumer.ConsumerRecords;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.clients.consumer.OffsetCommitCallback;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.errors.WakeupException;
@ -47,19 +48,15 @@ public class ConsumerWorker implements Runnable {
} catch (Exception e) {
log.info("[ConsumerWorker] Unexpected Exception. thread: {}", Thread.currentThread().getName());
} finally {
try {
consumer.commitSync();
log.info("[ConsumerWorker] Final offset committed. Close consumer.. ");
} catch (Exception e) {
log.error("[ConsumerWorker] Failed to commit final offsets when shutdown. thread: {}",
Thread.currentThread().getName());
} finally {
consumer.close();
log.info("[ConsumerWorker] Closed consumer thread. thread: {}", Thread.currentThread().getName());
}
closeAfterManualCommit();
}
}
public void shutdown() {
running.set(false);
consumer.wakeup();
}
private void commitAsync(ConsumerRecords<String, TestRecord> records) {
Map<TopicPartition, OffsetAndMetadata> offsets = records.partitions().stream()
.collect(Collectors.toMap(tp -> tp, tp -> {
@ -69,7 +66,7 @@ public class ConsumerWorker implements Runnable {
return new OffsetAndMetadata(lastOffset + 1);
}));
consumer.commitAsync(offsets, (o, exception) -> {
OffsetCommitCallback callback = (o, exception) -> {
if (exception != null) {
log.error("[ConsumerWorker] failed to commit offsets for offset: {}, partition {}", o,
records.partitions(), exception);
@ -77,11 +74,21 @@ public class ConsumerWorker implements Runnable {
log.debug("[ConsumerWorker] committed offsets for offset: {}, partition {}", o,
records.partitions());
}
});
};
consumer.commitAsync(offsets, callback);
}
public void shutdown() {
running.set(false);
consumer.wakeup();
private void closeAfterManualCommit() {
try {
consumer.commitSync();
log.info("[ConsumerWorker] Final offset committed. Close consumer.. ");
} catch (Exception e) {
log.error("[ConsumerWorker] Failed to commit final offsets when shutdown. thread: {}",
Thread.currentThread().getName());
} finally {
consumer.close();
log.info("[ConsumerWorker] Closed consumer thread. thread: {}", Thread.currentThread().getName());
}
}
}